Closed
Conversation
Added an optional feature that adds a leading zero to a number if it is smaller than 10. Updated docs as well.
You should be able to use elements as well as attributes and classes in your HTML markup
updated the code to use separate scope variables
Owner
|
I am trying to cut down an extra if check. How about removing add-leading-zero attribute directive & do this by default? |
Owner
|
Sorry the more I think about this, the more I am getting confused with options. Would adding a format-precision attribute would suffice in this case? Like for example would add 2 numeric precision to scope values. The flip side is, we cannot mix & match the precisions like for days you may not need 2 number precisions but for others you may need etc. |
Contributor
Author
|
Well logically it would only make sense to have more than 2 precisions for days, although I don't really see any use case for this at the moment... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option leading zero to timer. This is handy if you want to use the timer as a countdown clock. If the number is <10 it will add a leading zero to it.
I created separate scope variables for the format (ddays, mminutes, sseconds)
Updated docs.
I also set restrict to EAC because you should be able to use elements as well as attributes and classes in your markup,