Fix erroneous spelling of "illegal" in the codebase#78
Open
pzel wants to merge 1 commit intosmlsharp:masterfrom
Open
Fix erroneous spelling of "illegal" in the codebase#78pzel wants to merge 1 commit intosmlsharp:masterfrom
pzel wants to merge 1 commit intosmlsharp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was working through 「SML#で始める実践MLプログラミング」 I tried creating a record with field names such as
Apparently field names cannot start with
0, but the error I got was:The correct spelling is
illegal.I dug deeper and found the string
illeagalconsistently used across the codebase. This PR addresses all the instances I was able to track down.