SONARPY-192 Remove @ActivatedByDefault annotations

pynicolas · pynicolas · commit 81c5294669e8 · 2017-05-08T11:01:56.000+02:00
diff --git a/python-checks/src/main/java/org/sonar/python/checks/AfterJumpStatementCheck.java b/python-checks/src/main/java/org/sonar/python/checks/AfterJumpStatementCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = AfterJumpStatementCheck.CHECK_KEY)
-@ActivatedByDefault
 public class AfterJumpStatementCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S1763";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/BackticksUsageCheck.java b/python-checks/src/main/java/org/sonar/python/checks/BackticksUsageCheck.java
@@ -27,10 +27,8 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = BackticksUsageCheck.CHECK_KEY)
-@ActivatedByDefault
 public class BackticksUsageCheck extends PythonCheck {
   public static final String CHECK_KEY = "BackticksUsage";
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/BreakContinueOutsideLoopCheck.java b/python-checks/src/main/java/org/sonar/python/checks/BreakContinueOutsideLoopCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = BreakContinueOutsideLoopCheck.CHECK_KEY)
-@ActivatedByDefault
 public class BreakContinueOutsideLoopCheck extends PythonCheck {
 
   private static final String MESSAGE = "Remove this \"%s\" statement";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ClassNameCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ClassNameCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = ClassNameCheck.CHECK_KEY)
-@ActivatedByDefault
 public class ClassNameCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S101";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/CognitiveComplexityFunctionCheck.java b/python-checks/src/main/java/org/sonar/python/checks/CognitiveComplexityFunctionCheck.java
@@ -31,10 +31,8 @@
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = CognitiveComplexityFunctionCheck.CHECK_KEY)
-@ActivatedByDefault
 public class CognitiveComplexityFunctionCheck extends PythonCheck {
 
   private static final String MESSAGE = "Refactor this function to reduce its Cognitive Complexity from %s to the %s allowed.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/CollapsibleIfStatementsCheck.java b/python-checks/src/main/java/org/sonar/python/checks/CollapsibleIfStatementsCheck.java
@@ -28,11 +28,9 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 @Rule(key = CollapsibleIfStatementsCheck.CHECK_KEY)
-@ActivatedByDefault
 public class CollapsibleIfStatementsCheck extends PythonCheck {
   public static final String CHECK_KEY = "S1066";
   private static final String MESSAGE = "Merge this if statement with the enclosing one.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/CommentedCodeCheck.java b/python-checks/src/main/java/org/sonar/python/checks/CommentedCodeCheck.java
@@ -37,11 +37,10 @@
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonTokenType;
 import org.sonar.python.parser.PythonParser;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = CommentedCodeCheck.CHECK_KEY)
-@ActivatedByDefault
 public class CommentedCodeCheck extends PythonCheck {
+
   public static final String CHECK_KEY = "S125";
   public static final String MESSAGE = "Remove this commented out code.";
   private static final Parser<Grammar> parser = PythonParser.create(new PythonConfiguration(Charsets.UTF_8));
diff --git a/python-checks/src/main/java/org/sonar/python/checks/DuplicatedMethodFieldNamesCheck.java b/python-checks/src/main/java/org/sonar/python/checks/DuplicatedMethodFieldNamesCheck.java
@@ -32,11 +32,9 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 @Rule(key = DuplicatedMethodFieldNamesCheck.CHECK_KEY)
-@ActivatedByDefault
 public class DuplicatedMethodFieldNamesCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S1845";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/EmptyNestedBlockCheck.java b/python-checks/src/main/java/org/sonar/python/checks/EmptyNestedBlockCheck.java
@@ -29,11 +29,9 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 @Rule(key = EmptyNestedBlockCheck.CHECK_KEY)
-@ActivatedByDefault
 public class EmptyNestedBlockCheck extends PythonCheck {
   public static final String CHECK_KEY = "S108";
   private static final Predicate<AstNode> NOT_PASS_PREDICATE = new NotPassPredicate();
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ExecStatementUsageCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ExecStatementUsageCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = ExecStatementUsageCheck.CHECK_KEY)
-@ActivatedByDefault
 public class ExecStatementUsageCheck extends PythonCheck {
   public static final String CHECK_KEY = "ExecStatementUsage";
   @Override
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ExitHasBadArgumentsCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ExitHasBadArgumentsCheck.java
@@ -29,10 +29,8 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = ExitHasBadArgumentsCheck.CHECK_KEY)
-@ActivatedByDefault
 public class ExitHasBadArgumentsCheck extends PythonCheck {
 
   public static final String MESSAGE_ADD = "Add the missing argument.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/FieldDuplicatesClassNameCheck.java b/python-checks/src/main/java/org/sonar/python/checks/FieldDuplicatesClassNameCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = FieldDuplicatesClassNameCheck.CHECK_KEY)
-@ActivatedByDefault
 public class FieldDuplicatesClassNameCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S1700";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/FieldNameCheck.java b/python-checks/src/main/java/org/sonar/python/checks/FieldNameCheck.java
@@ -30,10 +30,8 @@
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = FieldNameCheck.CHECK_KEY)
-@ActivatedByDefault
 public class FieldNameCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S116";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/FixmeCommentCheck.java b/python-checks/src/main/java/org/sonar/python/checks/FixmeCommentCheck.java
@@ -25,11 +25,10 @@
 import java.util.regex.Pattern;
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = FixmeCommentCheck.CHECK_KEY)
-@ActivatedByDefault
 public class FixmeCommentCheck extends PythonCheck {
+
   public static final String CHECK_KEY = "S1134";
 
   private static final String FIXME_COMMENT_PATTERN = "^#[ ]*fixme.*";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/FunctionNameCheck.java b/python-checks/src/main/java/org/sonar/python/checks/FunctionNameCheck.java
@@ -21,10 +21,8 @@
 
 import com.sonar.sslr.api.AstNode;
 import org.sonar.check.Rule;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = FunctionNameCheck.CHECK_KEY)
-@ActivatedByDefault
 public class FunctionNameCheck extends AbstractFunctionNameCheck {
   public static final String CHECK_KEY = "S1542";
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/HardcodedIPCheck.java b/python-checks/src/main/java/org/sonar/python/checks/HardcodedIPCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonTokenType;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = HardcodedIPCheck.CHECK_KEY)
-@ActivatedByDefault
 public class HardcodedIPCheck extends PythonCheck {
   public static final String CHECK_KEY = "S1313";
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/IdenticalExpressionOnBinaryOperatorCheck.java b/python-checks/src/main/java/org/sonar/python/checks/IdenticalExpressionOnBinaryOperatorCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = "S1764")
-@ActivatedByDefault
 public class IdenticalExpressionOnBinaryOperatorCheck extends PythonCheck {
 
   private static final List<String> EXCLUDED_OPERATOR_TYPES = ImmutableList.of(
diff --git a/python-checks/src/main/java/org/sonar/python/checks/InequalityUsageCheck.java b/python-checks/src/main/java/org/sonar/python/checks/InequalityUsageCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = InequalityUsageCheck.CHECK_KEY)
-@ActivatedByDefault
 public class InequalityUsageCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "InequalityUsage";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/InitReturnsValueCheck.java b/python-checks/src/main/java/org/sonar/python/checks/InitReturnsValueCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = InitReturnsValueCheck.CHECK_KEY)
-@ActivatedByDefault
 public class InitReturnsValueCheck extends PythonCheck {
 
   public static final String MESSAGE_RETURN = "Remove this return value.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/LocalVariableAndParameterNameConventionCheck.java b/python-checks/src/main/java/org/sonar/python/checks/LocalVariableAndParameterNameConventionCheck.java
@@ -32,10 +32,8 @@
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = LocalVariableAndParameterNameConventionCheck.CHECK_KEY)
-@ActivatedByDefault
 public class LocalVariableAndParameterNameConventionCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S117";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/MethodNameCheck.java b/python-checks/src/main/java/org/sonar/python/checks/MethodNameCheck.java
@@ -21,10 +21,8 @@
 
 import com.sonar.sslr.api.AstNode;
 import org.sonar.check.Rule;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = MethodNameCheck.CHECK_KEY)
-@ActivatedByDefault
 public class MethodNameCheck extends AbstractFunctionNameCheck {
   public static final String CHECK_KEY = "S100";
   @Override
diff --git a/python-checks/src/main/java/org/sonar/python/checks/MethodShouldBeStaticCheck.java b/python-checks/src/main/java/org/sonar/python/checks/MethodShouldBeStaticCheck.java
@@ -29,10 +29,8 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonTokenType;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = MethodShouldBeStaticCheck.CHECK_KEY)
-@ActivatedByDefault
 public class MethodShouldBeStaticCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S2325";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/NeedlessPassCheck.java b/python-checks/src/main/java/org/sonar/python/checks/NeedlessPassCheck.java
@@ -28,11 +28,9 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonTokenType;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 @Rule(key = NeedlessPassCheck.CHECK_KEY)
-@ActivatedByDefault
 public class NeedlessPassCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S2772";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/NestedControlFlowDepthCheck.java b/python-checks/src/main/java/org/sonar/python/checks/NestedControlFlowDepthCheck.java
@@ -30,10 +30,8 @@
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = NestedControlFlowDepthCheck.CHECK_KEY)
-@ActivatedByDefault
 public class NestedControlFlowDepthCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S134";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/OneStatementPerLineCheck.java b/python-checks/src/main/java/org/sonar/python/checks/OneStatementPerLineCheck.java
@@ -28,14 +28,13 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 /**
  * Note that implementation differs from AbstractOneStatementPerLineCheck due to Python specifics
  */
 @Rule(key = OneStatementPerLineCheck.CHECK_KEY)
-@ActivatedByDefault
 public class OneStatementPerLineCheck extends PythonCheck {
+
   public static final String CHECK_KEY = "OneStatementPerLine";
   private final Map<Integer, Integer> statementsPerLine = Maps.newHashMap();
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/PreIncrementDecrementCheck.java b/python-checks/src/main/java/org/sonar/python/checks/PreIncrementDecrementCheck.java
@@ -28,10 +28,8 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = PreIncrementDecrementCheck.CHECK_KEY)
-@ActivatedByDefault
 public class PreIncrementDecrementCheck extends PythonCheck {
   public static final String CHECK_KEY = "PreIncrementDecrement";
   private static final String MESSAGE = "This statement doesn't produce the expected result, replace use of non-existent pre-%srement operator";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/PrintStatementUsageCheck.java b/python-checks/src/main/java/org/sonar/python/checks/PrintStatementUsageCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = PrintStatementUsageCheck.CHECK_KEY)
-@ActivatedByDefault
 public class PrintStatementUsageCheck extends PythonCheck {
   public static final String CHECK_KEY = "PrintStatementUsage";
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ReturnAndYieldInOneFunctionCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ReturnAndYieldInOneFunctionCheck.java
@@ -27,10 +27,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = ReturnAndYieldInOneFunctionCheck.CHECK_KEY)
-@ActivatedByDefault
 public class ReturnAndYieldInOneFunctionCheck extends PythonCheck {
 
   public static final String MESSAGE = "Use only \"return\" or only \"yield\", not both.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/ReturnYieldOutsideFunctionCheck.java b/python-checks/src/main/java/org/sonar/python/checks/ReturnYieldOutsideFunctionCheck.java
@@ -26,10 +26,8 @@
 import org.sonar.check.Rule;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = ReturnYieldOutsideFunctionCheck.CHECK_KEY)
-@ActivatedByDefault
 public class ReturnYieldOutsideFunctionCheck extends PythonCheck {
 
   public static final String MESSAGE = "Remove this use of \"%s\".";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/SameBranchCheck.java b/python-checks/src/main/java/org/sonar/python/checks/SameBranchCheck.java
@@ -32,13 +32,11 @@
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
 import org.sonar.python.api.PythonTokenType;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 import static org.sonar.python.api.PythonGrammar.STMT_LIST;
 
 @Rule(key = SameBranchCheck.CHECK_KEY)
-@ActivatedByDefault
 public class SameBranchCheck extends PythonCheck {
   public static final String CHECK_KEY = "S1871";
   public static final String MESSAGE = "Either merge this branch with the identical one on line \"%s\" or change one of the implementations.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/SameConditionCheck.java b/python-checks/src/main/java/org/sonar/python/checks/SameConditionCheck.java
@@ -30,11 +30,9 @@
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.sslr.ast.AstSelect;
 
 @Rule(key = SameConditionCheck.CHECK_KEY)
-@ActivatedByDefault
 public class SameConditionCheck extends PythonCheck {
   public static final String CHECK_KEY = "S1862";
   private static final String MESSAGE = "This branch duplicates the one on line %s.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/TooManyLinesInFileCheck.java b/python-checks/src/main/java/org/sonar/python/checks/TooManyLinesInFileCheck.java
@@ -28,11 +28,10 @@
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = TooManyLinesInFileCheck.CHECK_KEY)
-@ActivatedByDefault
 public class TooManyLinesInFileCheck extends PythonCheck {
+
   public static final String CHECK_KEY = "S104";
   private static final int DEFAULT = 1000;
 
diff --git a/python-checks/src/main/java/org/sonar/python/checks/TooManyParametersCheck.java b/python-checks/src/main/java/org/sonar/python/checks/TooManyParametersCheck.java
@@ -27,10 +27,8 @@
 import org.sonar.check.RuleProperty;
 import org.sonar.python.PythonCheck;
 import org.sonar.python.api.PythonGrammar;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = TooManyParametersCheck.CHECK_KEY)
-@ActivatedByDefault
 public class TooManyParametersCheck extends PythonCheck {
   public static final String CHECK_KEY = "S107";
   private static final String MESSAGE = "%s has %s parameters, which is greater than the %s authorized.";
diff --git a/python-checks/src/main/java/org/sonar/python/checks/UselessParenthesisCheck.java b/python-checks/src/main/java/org/sonar/python/checks/UselessParenthesisCheck.java
@@ -29,10 +29,8 @@
 import org.sonar.python.api.PythonGrammar;
 import org.sonar.python.api.PythonKeyword;
 import org.sonar.python.api.PythonPunctuator;
-import org.sonar.squidbridge.annotations.ActivatedByDefault;
 
 @Rule(key = UselessParenthesisCheck.CHECK_KEY)
-@ActivatedByDefault
 public class UselessParenthesisCheck extends PythonCheck {
 
   public static final String CHECK_KEY = "S1110";
