fix copy paste error in file.cpp#1707
Merged
phkahler merged 1 commit intosolvespace:masterfrom Apr 1, 2026
Merged
Conversation
Author
|
@phkahler |
Member
|
@g19fanatic Well that's awkward. I want to see if that's causing a bug prior to merging. Thanks for spotting it! |
Member
|
I searched group.cpp generate.cpp and textscreens.cpp and see no reference to it. Must currently be unused so I'll just merge this so it doesn't confuse us if we do use valC some day. |
Member
|
@g19fanatic Thank you for finding this! |
Member
|
@g19fanatic welcome to SolveSpace. Thank you for the fix. I'm very, very, very curious - how did you stumble upon this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a copy paste error in file.cpp.
Simple quick fix.