Add support for Explain Analyze for Postgres v13#1230
Add support for Explain Analyze for Postgres v13#1230yaojiejia wants to merge 5 commits intosqlancer:mainfrom
Conversation
mrigger
left a comment
There was a problem hiding this comment.
I think the code is currently used only by the Query Plan Guidance (QPG) component. If we execute ANALYZE for it, performance would drop. I guess we could have separate public methods, one for QPG and one that we use in the provider class.
I see, looking over the |
|
We could add an enum (see ). In this enum, we can specify a newly-created method in the explain generator that can generate the full range ofEXPLAIN, while we can keep using the restricted method for QPG.
|
|
@yaojiejia, I see you have been working on multiple other PRs. Do you think it would be possible to focus on the open ones, so we can merge those first? |
Of course, will prioritize these for now, thanks |
Just included a method for EXPLAIN. Lmk if this is something we are looking for |
| JIT("jit", (r) -> Randomly.fromOptions(1, 0)), | ||
| JOIN_COLLAPSE_LIMIT("join_collapse_limit", (r) -> r.getInteger(1, Integer.MAX_VALUE)), | ||
| PARALLEL_LEADER_PARTICIPATION("parallel_leader_participation", (r) -> Randomly.fromOptions(1, 0)), | ||
| FORCE_PARALLEL_MODE("force_parallel_mode", (r) -> Randomly.fromOptions("off", "on", "regress")), |
There was a problem hiding this comment.
This change seems unrelated. Can we remove this? Other than that, the PR looks good to go.
Closes 12. EXPLAIN ANALYSE from #912