Open
Conversation
20529cd to
ff85a6b
Compare
ff85a6b to
05bb28c
Compare
Author
|
@mrigger Can you take a look? |
mrigger
reviewed
Mar 26, 2026
Contributor
mrigger
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR and very sorry for the late review! This looks mostly great! Regarding the expected errors, there should be no syntax errors happening. Could you please check?
| errors.add("is not a valid grouping expression"); | ||
| errors.add("is not contained in either an aggregate function or the GROUP BY clause"); | ||
| errors.add("PARSE_SYNTAX_ERROR"); | ||
| errors.add("Syntax error"); |
Contributor
There was a problem hiding this comment.
Syntax errors should never happen. If they do, we should change the generators.
| } | ||
|
|
||
| public enum Action implements AbstractAction<SparkGlobalState> { | ||
| INSERT(SparkInsertGenerator::getQuery); // You will need to create this class |
Contributor
There was a problem hiding this comment.
I guess the comment is outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a basic framework for Spark SQL and uses the TLP oracle to test it via the Thrift Server.
Implemented JDBC connection to the Spark Thrift Server (using HiveServer2 protocol).
Implemented creating Spark tables (Parquet format) with basic column types (BOOLEAN, INT, DOUBLE, STRING, TIMESTAMP, DATE).
Implemented supported table constraint (NOT_NULL)
Implemented SELECT WHERE clause generation for the TLP
Inspired from #1201
Closes #1025
Ref:https://spark.apache.org/docs/latest/sql-ref.html
@mrigger