Skip to content

chore: remove replacemnt#81

Closed
janisz wants to merge 3 commits intomainfrom
remove_replacment
Closed

chore: remove replacemnt#81
janisz wants to merge 3 commits intomainfrom
remove_replacment

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Mar 19, 2026

Description

Validation

janisz
janisz commented Mar 19, 2026
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (7cb6989) to head (c6cd81d).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   78.49%   78.49%           
=======================================
  Files          28       28           
  Lines        1223     1223           
=======================================
  Hits          960      960           
  Misses        223      223           
  Partials       40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

E2E Test Results

Commit: c6cd81d
Workflow Run: View Details

=== Evaluation Summary ===

  ✓ list-clusters (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✗ cve-detected-clusters (assertions: 3/3)
      one or more verification steps failed
  ~ cve-nonexistent (assertions: 2/3)
      - MaxToolCalls: Too many tool calls: expected <= 5, got 9
  ✓ cve-cluster-does-exist (assertions: 3/3)
  ~ cve-cluster-does-not-exist (assertions: 2/3)
      - ToolsUsed: Required tool not called: server=stackrox-mcp, tool=, pattern=list_clusters
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)

Tasks:      10/11 passed (90.91%)
Assertions: 30/32 passed (93.75%)
Agent used tokens:
  Input:  33941 tokens
  Output: 21260 tokens
Judge used tokens:
  Input:  9024 tokens
  Output: 14507 tokens

mtodor
mtodor reviewed Mar 20, 2026
View reviewed changes
go.mod

github.com/stackrox/rox => github.com/stackrox/stackrox v0.0.0-20260319014210-a083ce72f963
)
replace github.com/stackrox/rox => github.com/stackrox/stackrox v0.0.0-20260319014210-a083ce72f963
Copy link
Copy Markdown
Collaborator

@mtodor mtodor Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error:

❯ go list -m -json all
go: github.com/heroku/[email protected]: invalid version: unknown revision v0.0.0
go: github.com/operator-framework/[email protected]: invalid version: unknown revision 000000000000

That command is used by goland. Without this, code completion does not work.

Copy link
Copy Markdown
Contributor Author

@janisz janisz Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get it. I tried to fix stackrox go.mod but I think scanner has similar go.mod entry so we need to fix the whole chain of docker-client usages https://github.com/stackrox/stackrox/pull/19508/changes

@janisz janisz closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtodor mtodor mtodor left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janisz @codecov-commenter @mtodor