Fix bug in Outer Tracker Barrel cabling map#663
Draft
gabrielribcesario wants to merge 1 commit intotkLayout:mainfrom
Draft
Fix bug in Outer Tracker Barrel cabling map#663gabrielribcesario wants to merge 1 commit intotkLayout:mainfrom
gabrielribcesario wants to merge 1 commit intotkLayout:mainfrom
Conversation
The `isLower` state variable was declared inside the for loop, causing it to be reassigned false at every iteration. This caused the majority of bundles to hit the fallback in `if (!isLowerAssigned)`.
16e33e0 to
d664304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in Outer Tracker Barrel cabling map
The
isLowerstate variable was declared inside thefor loop, causing it to be reassignedfalseat every iteration. This caused the majority of bundles to hit the fallback inif (!isLowerAssigned).This commit fixes #659.