Skip to content

[image_picker] feat:ios camera overlays#1

Open
tsinis wants to merge 34 commits intomainfrom
feat/ios-camera-overlay
Open

[image_picker] feat:ios camera overlays#1
tsinis wants to merge 34 commits intomainfrom
feat/ios-camera-overlay

Conversation

@tsinis
Copy link
Copy Markdown
Owner

@tsinis tsinis commented Oct 27, 2022

Added overlays to camera view on iOS.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

tsinis added 15 commits October 26, 2022 23:32
@tsinis
model: added overlayOpacity and overlayImage the platform interface
d60da6e
@tsinis
model(dart): added overlayOpacity and overlayImage the ios
23b7a49
@tsinis
model(objc): added overlayOpacity and overlayImage the ios
8a009e3
@tsinis
fix(tests): fixing platform interface tests
c660642
@tsinis
docs(interface): added required documentation to new fields
6615823
@tsinis
docs(objc): added comments in overlay view class
84c8822
@tsinis
feat(example): update example ios app with overlay
c25697a
@tsinis
chore(deps): path reference in image_picker_ios pubspec
2f0010b
@tsinis
chore(deps): added dependency_overrides for ios and platform interface
15a981a
@tsinis
fix(deps): fixed ref to git for ios package
48d2103
@tsinis
fix(deps): fixed ref to git for main package
2359213
@tsinis
chore(deps): ref to git for android and web
4951b00
@tsinis
fix: added new arguments to all interfaces
97cd734
@tsinis
fix(example): git reference in example
aa580cd
@tsinis
fix(tests): fixing packages tests
abdfea9
@tsinis tsinis added the enhancement New feature or request label Oct 27, 2022
@tsinis tsinis self-assigned this Oct 27, 2022
@tsinis tsinis requested a review from akaTJ October 27, 2022 11:18
akaTJ
akaTJ approved these changes Oct 29, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@akaTJ akaTJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done

@tsinis
Copy link
Copy Markdown
Owner Author

tsinis commented Nov 1, 2022

LGTM, nicely done

Could you please check it again, I've had to create a custom UI image picker at the end of the day (but it's just inherited from the default one, with overridden fields and notification observer), but good thing is, that we don't have those overlays on the preview screen (with Retake and Use Photo buttons).

@tsinis tsinis mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaTJ akaTJ akaTJ approved these changes

Assignees

@tsinis tsinis

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsinis @akaTJ