✨ Quality: Potential NullReferenceException when accessing MainWindow.unityInstallationsSource#220
Closed
halinhtvn3a wants to merge 1 commit intounitycoder:masterfrom
Conversation
…unityinstallationssource The code accesses `MainWindow.unityInstallationsSource` without null checking. If this static property is null (e.g., during initialization or if scanning failed), the assignment `gridAvailableVersions.ItemsSource = MainWindow.unityInstallationsSource` will throw a NullReferenceException, crashing the window initialization. This is a production crash risk. Affected files: UpgradeWindow.xaml.cs Signed-off-by: halinhtvn3a <[email protected]>
Author
Auto-closed: CI checks failedThe following checks failed: SonarCloud Code Analysis Closing this PR since required CI checks did not pass. Sorry for the inconvenience. |
|
Owner
|
thanks, i modified few other parts related to that same null list issues, so i'll close this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
The code accesses
MainWindow.unityInstallationsSourcewithout null checking.If this static property is null (e.g., during initialization or if scanning failed),
the assignment
gridAvailableVersions.ItemsSource = MainWindow.unityInstallationsSourcewill throw a NullReferenceException, crashing the window initialization.
This is a production crash risk.
Severity:
mediumFile:
UnityLauncherPro/UpgradeWindow.xaml.csSolution
Add a null check before assignment:
Changes
UnityLauncherPro/UpgradeWindow.xaml.cs(modified)Testing
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #219