Open
Conversation
Member
Author
|
@ehellbar this possibly resumes performance of the QC task which got slower. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 5ea5aae at 2026-04-03 15:30: Full log here. |
Now that navigating the MessageSet does not have an index anymore it does not make sense to use a random accessor to implement the InputSpan::Iterator, because that results in an O(N^2) loop for normal linear iterations. It is much better to simply implement a proper advancement operator, so that looping stays O(N). This resumes the performance when iterating on old-style multiparts which are apparently still used in some cases. General modernization of InputSpan also done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that navigating the MessageSet does not have an index anymore
it does not make sense to use a random accessor to implement the
InputSpan::Iterator, because that results in an O(N^2) loop for
normal linear iterations. It is much better to simply implement
a proper advancement operator, so that looping stays O(N).
This resumes the performance when iterating on old-style multiparts
which are apparently still used in some cases.
General modernization of InputSpan also done.