Merged
Conversation
NoahvdAa
reviewed
Sep 17, 2024
| boolean logResponseStatusText = config.getBoolean("logResponseStatusText", false); | ||
|
|
||
| String minecraftVersion2 = Bukkit.getServer().getName(); | ||
| boolean folia = (minecraftVersion2.toUpperCase().contains("FOLIA")); |
There was a problem hiding this comment.
This wouldn't catch forks of folia, you should detect if the class io.papermc.paper.threadedregions.RegionizedServer exists instead.
Bastian
approved these changes
Sep 22, 2024
Owner
Bastian
left a comment
There was a problem hiding this comment.
Just a few small code changes, but overall looks good to me.
Thanks for the PR! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubmitTaskConsumer seems to halt processing on the scheduler with Folia and since the scheduler itself is usable in schedule and scheduleAtFixedRate methods, so on folia version it is passed a null in order to force call this.submitData().
Tested with auto-generated Metrics class for bukkit with the changes presented here with bstats https://bstats.org/plugin/bukkit/CoolGateway/23166
Regards