fix: handle multiple IContextCheck interfaces in AddChecks#2425
Closed
Sim-hu wants to merge 1 commit intoDSharpPlus:masterfrom
Closed
fix: handle multiple IContextCheck interfaces in AddChecks#2425Sim-hu wants to merge 1 commit intoDSharpPlus:masterfrom
Sim-hu wants to merge 1 commit intoDSharpPlus:masterfrom
Conversation
Use GetInterfaces() instead of GetInterface() to avoid AmbiguousMatchException when a class implements multiple IContextCheck<T> interfaces. Fixes DSharpPlus#2262
Member
|
what specifically do you mean by "keeps things consistent"? |
Author
|
The single-type AddCheck(Type) overload already uses GetInterfaces() with a namespace/name check (around line 343). This PR just brings AddChecks(Assembly) in line with that same approach instead of using GetInterface(). |
Member
|
given the author's account, closing as AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class implements more than one
IContextCheck<T>interface,AddChecks(Assembly)throws anAmbiguousMatchExceptionbecause it usesType.GetInterface()which only expects a single match.This switches to
GetInterfaces()with a predicate to find the right interface by namespace and name, which is the same approach already used in the single-typeAddCheck(Type)overload. Keeps things consistent and fixes the crash.Fixes #2262