Skip to content

fix(release_homebrew): print all output for audit failures#29

Merged
ReenigneArcher merged 2 commits intomasterfrom
fix/release_homebrew/print-all-output-for-audit-failures
Sep 7, 2025
Merged

fix(release_homebrew): print all output for audit failures#29
ReenigneArcher merged 2 commits intomasterfrom
fix/release_homebrew/print-all-output-for-audit-failures

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented Sep 7, 2025

Description

This PR adjusts the code to ensure that multiple line output is printed. For example when a brew audit failed, only one line would be printed.

Additionally, the cognitive complexity has been reduced for the _run_subprocess command since Sonar complained about it.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0bb674b) to head (74444d8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          387       408   +21     
=========================================
+ Hits           387       408   +21     
Flag Coverage Δ
Linux 100.00% <100.00%> (ø)
Windows 65.68% <20.58%> (-2.28%) ⬇️
macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/release_homebrew/main.py 100.00% <100.00%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the fix/release_homebrew/print-all-output-for-audit-failures branch from 01a468b to 0f0fb44 Compare September 7, 2025 01:46
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 7, 2025

@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 7, 2025 02:07
@ReenigneArcher ReenigneArcher merged commit 46460a6 into master Sep 7, 2025
53 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/release_homebrew/print-all-output-for-audit-failures branch September 7, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant