Skip to content

Make upgradeTo and upgradeToAndCall public#3959

Merged
frangio merged 8 commits intoOpenZeppelin:masterfrom
m-waqas88:fix/make-functions-public-#3923
Jan 25, 2023
Merged

Make upgradeTo and upgradeToAndCall public#3959
frangio merged 8 commits intoOpenZeppelin:masterfrom
m-waqas88:fix/make-functions-public-#3923

Conversation

@m-waqas88
Copy link
Copy Markdown
Contributor

@m-waqas88 m-waqas88 commented Jan 16, 2023 •
edited by frangio
Loading

Fixes #3923

Two functions upgradeTo and upgradeToAndCall were having visibility specifiers as external and virtual, due to this reason derived contract was not able to invoke the function using super keyword. I just replaced external with public so that it can be invoked as well as overridden as expected.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

JulissaDantes
JulissaDantes suggested changes Jan 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the other contracts using the UUPSUpgradeable contract. All the check must pass, and right now the library its not compiling.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 22, 2023

⚠️ No Changeset found

Latest commit: dd4d0d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx requested changes Jan 23, 2023
View reviewed changes
Comment thread .changeset/five-ducks-develop.md
JulissaDantes
JulissaDantes reviewed Jan 24, 2023
View reviewed changes
Comment thread .changeset/five-ducks-develop.md
@frangio frangio changed the title fix: make upgradeTo and upgradeToAndCall functions public (#3923) Make upgradeTo and upgradeToAndCall public Jan 24, 2023
@m-waqas88 m-waqas88 requested review from Amxx and JulissaDantes and removed request for Amxx January 25, 2023 12:33
frangio
frangio approved these changes Jan 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@frangio frangio merged commit 69c8d10 into OpenZeppelin:master Jan 25, 2023
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Jan 25, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@frangio frangio mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amxx Amxx Amxx requested changes

@frangio frangio frangio approved these changes

@JulissaDantes JulissaDantes Awaiting requested review from JulissaDantes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make upgradeTo functions public

4 participants

@m-waqas88 @frangio @Amxx @JulissaDantes