Skip to content

Add IERC4906 interface and use in ERC721#4012

Merged
Amxx merged 9 commits intoOpenZeppelin:masterfrom
Amxx:interfaces/erc/4906
Feb 17, 2023
Merged

Add IERC4906 interface and use in ERC721#4012
Amxx merged 9 commits intoOpenZeppelin:masterfrom
Amxx:interfaces/erc/4906

Conversation

@Amxx
Copy link
Copy Markdown
Collaborator

@Amxx Amxx commented Jan 30, 2023 •
edited
Loading

EIP is final: https://eips.ethereum.org/EIPS/eip-4906

PR Checklist

  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 31119cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frangio frangio added this to the 4.9 milestone Feb 16, 2023
@frangio frangio changed the title Add IERC4906 interface Add IERC4906 interface and use in ERC721 Feb 16, 2023
frangio
frangio approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a changeset for ERC721URIStorage. LGTM.

@Amxx Amxx enabled auto-merge (squash) February 17, 2023 09:08
@Amxx Amxx merged commit 96a2297 into OpenZeppelin:master Feb 17, 2023
@pcaversaccio
Copy link
Copy Markdown
Contributor

pcaversaccio commented Feb 17, 2023

Hey, maybe am wrong here but I was just going through these changes - one question: shouldn't you add a test here as well? I noted that the interface ID 0x49064906 for IERC4906 is kinda special since it does not have any functions (not sure how it was calculated, maybe you know?), so makeInterfaceId wouldn't work.

@Amxx
Copy link
Copy Markdown
Collaborator Author

Amxx commented Feb 17, 2023

That is a good point. In fact in ERC721Storage we did not add ERC165 support for 0x49064906.

@Amxx Amxx deleted the interfaces/erc/4906 branch February 17, 2023 14:18
@pcaversaccio
Copy link
Copy Markdown
Contributor

pcaversaccio commented Feb 17, 2023

Right, btw I quickly asked about the interfaceId and it was chosen randomly.

@Amxx Amxx mentioned this pull request Feb 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frangio frangio frangio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@Amxx @pcaversaccio @frangio