[Debug] Add "Missed" to worker status stats.#2063
Open
neskk wants to merge 1 commit intoRocketMap:developfrom
Open
[Debug] Add "Missed" to worker status stats.#2063neskk wants to merge 1 commit intoRocketMap:developfrom
neskk wants to merge 1 commit intoRocketMap:developfrom
Conversation
Contributor
|
Good one :-) |
|
What about adding a message to log when a LVL 30 account is sent for an encounter but doesn't see the pokemon it should encounter ? That would mean a low level account could see it but your lvl 30 couldn't see it, so it's shadowbanned... Would make it very easy to identify shadowbans at least for high level accounts. Even better with some increment "L30 account xxx could not encounter a pokemon for xx times in a row". Would be even better to add this info in workerstatus table but I don't think Lvl 30 accounts are in there... Commenting on this PR as the objective is the same, help identify "blind" accounts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for debug purposes and it updates database schema version - just one tiny modification to
workerstatustable - if you want to reverse the update, drop the table, revert schema version to 19 and you're good.It adds "Missed" column to status page and status printer (console) to track missed spawnpoints. The idea came from @aRengo and I decided to do a branch isolating this change.
Description
Adds a new statistic to WorkerStatus:
missed- that tracks whenever a spawnpoint is missed by the worker when map request is parsed. This can happen because account is "shadowed/blind" or if spawnpoint data is old and outdated.Motivation and Context
Get more information on "shadowed/blind" accounts and how to identify them.
How Has This Been Tested?
Tested in local environment and server with several instances.
Screenshots (if appropriate):
Types of changes
Checklist: