Conversation
7cb859c to
506a5e2
Compare
static/data/sprites_map.json
Outdated
| @@ -0,0 +1,2541 @@ | |||
| { | |||
There was a problem hiding this comment.
This shouldn't be in the PR.
.gitignore
Outdated
| static/icons-sprite.png | ||
| static/icons-large-sprite.png | ||
| static/icons/*.png | ||
| static/sass/sprite.sass |
There was a problem hiding this comment.
It should be static/sass/sprite.scss
Missing static/data/sprites_map.json and static/spritesheet.png
476b13d to
3439f06
Compare
a790c9c to
e40d0c6
Compare
|
Can we use just a "?" on unknown raid boss in same font/size/style as the standard circles/numbers? |
sirlindqvist
left a comment
There was a problem hiding this comment.
Using 'rebuild = true' in 'static/js/build_icons.js' overwrite custom icons with default numbers/circles.
|
This is a very "needed" feature, and the amount of work that has been put into this is tremendous. Well done. My system: Windows Server 2012
The sprites are generated in a timely (I guess) fashion and is also replaced by custom ones in the spritesheet if you put custom ones in. The resulting spritesheet for some custom images is 19,697 kB - this feels like a lot when the current one is sitting around 2,256kB for icons-large-sprite.png Lastly there seems to be some antialiasing/resizing issues going on if you use large high quality source images: For normal icon size the map sprites are quite a bit fuzzier than before This could be an artifact of the raw size of the icons - but there's a absolutely a difference from current spritesheet quality. Using smaller icons to generate the spritesheet gives a better quality for normal sized sprites: |
|
Apparently I forgot the 'karp. (Cheers @sirlindqvist 😄 ) |
|
Yopp, now rebase proper! |
|
does this handle pokemon forms for spritegen? is it possible to also pull in the sprites for costume from #2461 |
|
It adds support for Pokemon forms, but it doesn't add support for costumes. That's a possible addition - I'll consider adding it to the PR. But this PR is already quite large (and behind schedule) so that may get delegated to a followup PR. |
Description
This moves all* of the images used by the project into a single spritesheet.
* 'all' doesn't include:
markercluster.jsdoesn't support thisMotivation and Context
The current sprite system requires a lot of manual work in order to issue new sprites. This PR aims to make the process for generating sprites much easier.
Additionally, this should make using custom (potentially map-specific) icons much easier.
Shoutout to @sirlindqvist for their help and advice throughout putting this together 🥇 .
How Has This Been Tested?
Small local map.
Screenshots (if appropriate):
Types of changes
Checklist: