Correct the Typescript defs for turf.voronoi.#1424
Merged
Conversation
Wassim24
approved these changes
Jul 4, 2018
2 tasks
|
Can any one please merge Pull request, its open from Jun 24, 2018. Its stopping us from using turfJs voronoi in typescript environment. |
Naitik333
approved these changes
Dec 19, 2019
mfedderly
approved these changes
Mar 12, 2020
Collaborator
mfedderly
left a comment
There was a problem hiding this comment.
Good catch, this is a breaking change but it is also just wrong on master so lets get it merged to fix that.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1422.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.