Improve TypeScript declaration of @turf/points-within-polygon#1761
Merged
mfedderly merged 2 commits intoTurfjs:masterfrom Mar 12, 2020
Merged
Improve TypeScript declaration of @turf/points-within-polygon#1761mfedderly merged 2 commits intoTurfjs:masterfrom
mfedderly merged 2 commits intoTurfjs:masterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm testat the sub modules where changes have occurred.The tests crash with me locally, but I tried linking the package to the project I'm working on and the types work.
npm run lintto ensure code style at the turf module level.Lint also doesn't work for me locally, but it should be ok I guess.
This PR improves the TypeScript declaration for
points-within-polygonto make sure the output points contain the same GeoJSON properties as the input points.