lineToPolygon fix. Resolves #1812#1879
Merged
mfedderly merged 6 commits intoTurfjs:masterfrom May 4, 2020
Merged
Conversation
…s called. An optional mutate prop has been added to options. If true the input will be modified, if false (default) the input will not be modified.
mfedderly
requested changes
Apr 13, 2020
Collaborator
mfedderly
left a comment
There was a problem hiding this comment.
@rowanwins This is potentially an API break because the default behavior is changing. Do you want to ship this as a bugfix anyhow?
Member
|
I think this is fine as a bugfix even though the default behaviour is changing. |
rowanwins
approved these changes
May 2, 2020
Member
rowanwins
left a comment
There was a problem hiding this comment.
Looks good to me. Ensuring inputs aren't modified, or at least making people flag that they are comfortable with inputs being modified, is the preferred behaviour.
mfedderly
approved these changes
May 4, 2020
Collaborator
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the input is by default not modified when lineToPolygon is called. Resolves #1812
An optional mutate prop has been added to options. If true the input will be modified, if false (default) the input will not be modified.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.