Include MultiLineString output type for greatCircle module#1928
Merged
mfedderly merged 3 commits intoTurfjs:masterfrom Nov 17, 2020
Merged
Include MultiLineString output type for greatCircle module#1928mfedderly merged 3 commits intoTurfjs:masterfrom
greatCircle module#1928mfedderly merged 3 commits intoTurfjs:masterfrom
Conversation
be22a50 to
2439f49
Compare
Contributor
Author
|
@rowanwins Thanks for the ✅ — will you handle merging this for the next release? Is there anything else I need to do? |
|
I'd love to see these changes in a new release as soon as possible 👍 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Typescript type definitions and corresponding docs for the
greatCirclefunction to include the possibility of returning aMultiLineStringwhen the input spans the antimeridian. This is described as expected behavior in this issue. Without this fix, Typescript will return an error if you try to test, for example:Typescript complains:
This condition will always return 'false' since the types '"LineString" | undefined' and '"MultiLineString"' have no overlap.