[@turf/tag] Confirm support for multipolygons and add to TypeScript definitions#1996
Merged
mfedderly merged 3 commits intoTurfjs:masterfrom Jan 11, 2021
bryceroney:add-multipolygons-tag
Merged
[@turf/tag] Confirm support for multipolygons and add to TypeScript definitions#1996mfedderly merged 3 commits intoTurfjs:masterfrom bryceroney:add-multipolygons-tag
mfedderly merged 3 commits intoTurfjs:masterfrom
bryceroney:add-multipolygons-tag
Conversation
mfedderly
approved these changes
Jan 11, 2021
Collaborator
mfedderly
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding the tests as well!
The yarn.lock change was leftover from a different PR but has already been fixed on the master branch. After updating your PR with the latest it went away.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there
This is my first time contributing to a large OSS project, so I hope I have met the requirements in the contributing guide.
I've started using TypeScript more for my JavaScript projects, and when working on a project using turf noticed that the definitions for
@turf/tagdo not include MultiPolygon as well as Polygon.This PR adds that definition to the TypeScript file, but also adds tests to ensure it does work if changes are made to
@turf/boolean-point-in-polygonI am not sure why yarn.lock changed.