Add .js to relative import statements in es output at build time#2011
Merged
Add .js to relative import statements in es output at build time#2011
Conversation
Collaborator
Author
|
@lcrosetto FYSA |
rowanwins
approved these changes
Jan 18, 2021
Member
rowanwins
left a comment
There was a problem hiding this comment.
I set this up locally and it seems straight forward enough, a bit finickity that we have to do it but 🤷♂️ what can you do, maybe one day we'll be able to dispense with it.
Thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1942 (comment) it was pointed out that Turf does not quite work in Webpack 5 without a workaround.
This change adds a build-time transform onto the dist/es output files that adds the .js extensions to all of the outputs.
I would have preferred to specify the .js extension directly in the imports in the source, but that was not working well with the way we use ts-node to run test and bench. I'm a little worried that this is a little fragile because it is a regular expression, but I'm hoping that this ages gracefully and prevents us from needing an entire codemod framework to do the same thing.