[@turf/line-slice-along] Fix offset distance equal to line length#2030
Merged
mfedderly merged 2 commits intoTurfjs:masterfrom Feb 14, 2021
Merged
[@turf/line-slice-along] Fix offset distance equal to line length#2030mfedderly merged 2 commits intoTurfjs:masterfrom
mfedderly merged 2 commits intoTurfjs:masterfrom
Conversation
This was referenced Jun 17, 2021
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@turf/line-slice-alongcurrently returns an invalid GeoJSONLineStringif you pass in an offset that is equal to the line length.The end of the module returns:
Which results in:
This is a Point and not a valid LineString geometry (list of coordinates). The modification here returns the last point as a valid LineString geometry.