Work towards enabling typescript's strict mode#2053
Merged
Conversation
JamesLMilner
approved these changes
Jun 16, 2021
Collaborator
JamesLMilner
left a comment
There was a problem hiding this comment.
This looks good to me - should resolve #2017
This was referenced Jun 17, 2021
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't everything for typescript's strict mode, but its most of it.
For the most part this is just using what the jsdoc comments were, or inferring the types and making sure the compiler was happy. For the most part no behavior changed, except for
@turf/boolean-crosseswhere the MultiPoint+Polygon case was just wrong.Still to do after this PR, most of them require types getting added to DefinitelyTyped. I'll work on that later.