feat(compiler-cli): ensure template style elements are preprocessed as inline styles#57429
Closed
clydin wants to merge 1 commit intoangular:mainfrom
Closed
feat(compiler-cli): ensure template style elements are preprocessed as inline styles#57429clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
fa3e01d to
a4b9e39
Compare
…s inline styles Previously, style elements within a template were used directly and not provided to the optional transformation step that may be present on the resource host interface. This causes such styles to not be processed by the Angular CLI's stylesheet pipeline and could cause the styles to not work properly on all browsers. The style elements are now processed in the same manner as inline styles within a component's metadata. Link elements within a stylesheet were already being processed as `styleUrls` equivalent and there is no behavior change in that regard.
a4b9e39 to
9312e07
Compare
JoostK
approved these changes
Aug 19, 2024
Member
JoostK
left a comment
There was a problem hiding this comment.
LGTM with the suggestion to retarget as feat for just main.
Contributor
|
This PR was merged into the repository by commit 9e87593. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, style elements within a template were used directly and not provided to the optional transformation step that may be present on the resource host interface. This causes such styles to not be processed by the Angular CLI's stylesheet pipeline and could cause the styles to not work properly on all browsers. The style elements are now processed in the same manner as inline styles within a component's metadata. Link elements within a stylesheet were already being processed as
styleUrlsequivalent and there is no behavior change in that regard.