fix(core): add missing ATTRIBUTE_NO_BINDING for SVG set element values/from#68032
Open
mohammadmseet-hue wants to merge 3 commits intoangular:mainfrom
Open
fix(core): add missing ATTRIBUTE_NO_BINDING for SVG set element values/from#68032mohammadmseet-hue wants to merge 3 commits intoangular:mainfrom
mohammadmseet-hue wants to merge 3 commits intoangular:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
set|valuesandset|fromentries to theATTRIBUTE_NO_BINDINGsecurity context, matching the existing protection on<animate>.Problem
PR #67797 added
ATTRIBUTE_NO_BINDINGprotection for SVG animation attributes to preventjavascript:URI injection via animatedhref. The fix protected<animate>completely (attributeName,to,from,values) but only partially protected<set>(attributeName,to).The
<set>element'svaluesandfromattributes were not registered in either:dom_security_schema.ts—set|valuesandset|frommissing fromATTRIBUTE_NO_BINDINGlistsanitization.ts—SECURITY_SENSITIVE_ELEMENTS['set']missingvaluesandfromPer SVG Animation (SMIL) specification,
<set>inherits thevaluesattribute fromAnimationElement. The first value in the semicolon-separated list is used as the target value, equivalent to thetoattribute.Fix
Add
set|valuesandset|fromto both the compile-time security schema and runtime validation check, matching the existing entries for<animate>.Test plan
animate|valuesandanimate|fromare already protectedset|valuesandset|fromare NOT protected before this fix