[ruff] Parenthesize generator expressions in f-strings (RUF010)#19434
Merged
ntBre merged 3 commits intoastral-sh:mainfrom Jul 30, 2025
Merged
[ruff] Parenthesize generator expressions in f-strings (RUF010)#19434ntBre merged 3 commits intoastral-sh:mainfrom
ruff] Parenthesize generator expressions in f-strings (RUF010)#19434ntBre merged 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
ntBre
reviewed
Jul 28, 2025
ntBre
approved these changes
Jul 30, 2025
| } | ||
|
|
||
| // Check precedence for other expressions | ||
| needs_paren(OperatorPrecedence::from_expr(arg)) |
Contributor
There was a problem hiding this comment.
This is fine for now, but I wonder if a better fix would be to handle unparenthesized generator expressions differently in OperatorPrecedence::from_expr. It doesn't really seem to fit into the rest of the precedence hierarchy, though.
ruff] Fix RUF010 to parenthesize generator expressions in f-stringsruff] Parenthesize generator expressions in f-strings (RUF010)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19433