Skip to content

fix(lsp): regression codeAction/resolve#9745

Merged
ematipico merged 2 commits intomainfrom
fix/lsp-organize-imports
Mar 31, 2026
Merged

fix(lsp): regression codeAction/resolve#9745
ematipico merged 2 commits intomainfrom
fix/lsp-organize-imports

Conversation

@ematipico
Copy link
Copy Markdown
Member

@ematipico ematipico commented Mar 31, 2026 •
edited
Loading

Summary

Closes #9741

Used an agent to track down the issue and create the test.

Test Plan

Added a new test

Docs

@ematipico ematipico requested review from a team March 31, 2026 09:13
@github-actions github-actions Bot added A-Linter Area: linter A-LSP Area: language server protocol labels Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 31, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 20a8de4f-2e96-4dcc-8d59-9eb7c90fbafe

📥 Commits

Reviewing files that changed from the base of the PR and between 57aa873 and 729bb48.

📒 Files selected for processing (1)
  • crates/biome_analyze/src/rule.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/biome_analyze/src/rule.rs

Walkthrough

The change ensures the LSP server emits the correct code action kind for the organizeImports source action when clients filter by source.organizeImports.biome. Rule metadata now maps the organizeImports action name to SourceActionKind::OrganizeImports instead of a generic kind. A changeset documents the patch release and a new regression test verifies the code action is returned when the only filter is set.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main fix: resolving the codeAction/resolve regression that filtered out organizeImports.
Description check ✅ Passed The description references the linked issue (#9741) and mentions adding a test, which aligns with the changeset and code modifications.
Linked Issues check ✅ Passed The PR successfully addresses issue #9741 by fixing the action category mismatch and adding a regression test to prevent recurrence.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the organizeImports filtering issue: correcting the category format, updating rule metadata logic, and adding a test.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lsp-organize-imports

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 31, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks1

Comparing fix/lsp-organize-imports (729bb48) with main (fcf216d)

Open in CodSpeed

Footnotes

  1. 196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico ematipico merged commit d87073e into main Mar 31, 2026
29 checks passed
@ematipico ematipico deleted the fix/lsp-organize-imports branch March 31, 2026 14:27
@github-actions github-actions Bot mentioned this pull request Mar 31, 2026
Merged
@elliotcourant elliotcourant mentioned this pull request Apr 5, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 11, 2026
Draft
@ematipico ematipico mentioned this pull request Apr 13, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter A-LSP Area: language server protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 LSP organizeImports code action is filtered out in 2.4.10

2 participants

@ematipico @dyc3