fix(graphql_analyze): also flag duplicate fields within extensions by Netail · Pull Request #9869 · biomejs/biome

Netail · 2026-04-08T18:56:19Z

Summary

Flag duplicate fields within graphql type extensions, interface extensions & input extensions. Not cross definitions & extensions yet, opened a ticket for that, but is blocked by the schema service

Saw parsing issue in another rule's snapshot & added Any* in front of union

Test Plan

Unit tests

Docs

changeset-bot · 2026-04-08T18:56:28Z

🦋 Changeset detected

Latest commit: 8753a03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2026-04-08T19:05:55Z

Merging this PR will not alter performance

✅ 9 untouched benchmarks
⏩ 247 skipped benchmarks¹

_{Comparing fix/extensions (8753a03) with main (e8cad58)}

247 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai · 2026-04-08T19:06:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e057b901-df82-4452-b21b-3cd0864e9e49

📥 Commits

Reviewing files that changed from the base of the PR and between d8bba5d and 8753a03.

📒 Files selected for processing (1)

.changeset/tender-owls-arrive.md

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/tender-owls-arrive.md

Walkthrough

The GraphQL linter rules were broadened to consider type, interface and input extensions when checking for duplicate field names. The noDuplicateFieldDefinitionNames rule’s query type was renamed from NoDuplicateFieldDefinitionNamesQuery to AnyNoDuplicateFieldDefinitionNamesQuery and now includes Graphql*TypeExtension variants; NoRootTypeQuery was similarly renamed to AnyNoRootTypeQuery. Tests were expanded to cover duplicate and valid cases that use extend blocks.

Suggested reviewers

siketyan

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: flagging duplicate fields within GraphQL extensions, which directly matches the primary objective of the pull request.
Description check	✅ Passed	The description is related to the changeset, explaining the scope of duplicate field detection in extensions and mentioning the renaming of union types for clarity.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/extensions

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/tender-owls-arrive.md:
- Line 5: Update the changeset description to include a user-facing link to the
rule documentation instead of plain code formatting: reference the rule name
"noDuplicateFieldDefinitionNames" as a markdown link to its docs (e.g.
[noDuplicateFieldDefinitionNames](https://your-docs-site/.../noDuplicateFieldDefinitionNames)),
and if this is a bug fix also reference the issue with a link (e.g. Fixed
[`#4444`](...)); ensure the sentence reads like user-facing copy rather than
inline code and replace the current backticked rule name with the linked form.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1599cad-3f9d-4639-91be-d7d5bf1f96f9

📥 Commits

Reviewing files that changed from the base of the PR and between e8cad58 and ff38abd.

⛔ Files ignored due to path filters (2)

crates/biome_graphql_analyze/tests/specs/nursery/noDuplicateFieldDefinitionNames/invalid.graphql.snap is excluded by !**/*.snap and included by **
crates/biome_graphql_analyze/tests/specs/nursery/noDuplicateFieldDefinitionNames/valid.graphql.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/tender-owls-arrive.md
crates/biome_graphql_analyze/src/lint/nursery/no_duplicate_field_definition_names.rs
crates/biome_graphql_analyze/src/lint/nursery/no_root_type.rs
crates/biome_graphql_analyze/tests/specs/nursery/noDuplicateFieldDefinitionNames/invalid.graphql
crates/biome_graphql_analyze/tests/specs/nursery/noDuplicateFieldDefinitionNames/valid.graphql

fix(graphql_analyze): also flag duplicate fields within extensions

ff38abd

Netail marked this pull request as draft April 8, 2026 18:57

github-actions bot added the A-Linter Area: linter label Apr 8, 2026

coderabbitai bot reviewed Apr 8, 2026

View reviewed changes

Comment thread .changeset/tender-owls-arrive.md Outdated

fix: parsing issues

d8bba5d

Netail marked this pull request as ready for review April 8, 2026 19:11

fix: feedback ai

8753a03

Netail requested a review from dyc3 April 8, 2026 21:14

ematipico approved these changes Apr 9, 2026

View reviewed changes

Netail merged commit 78bce77 into main Apr 9, 2026
18 checks passed

Netail deleted the fix/extensions branch April 9, 2026 07:48

github-actions bot mentioned this pull request Apr 8, 2026

ci: release #9733

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(graphql_analyze): also flag duplicate fields within extensions#9869

fix(graphql_analyze): also flag duplicate fields within extensions#9869
Netail merged 3 commits intomainfrom
fix/extensions

Netail commented Apr 8, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Netail commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

coderabbitai bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Netail commented Apr 8, 2026 •

edited

Loading

changeset-bot bot commented Apr 8, 2026 •

edited

Loading

codspeed-hq bot commented Apr 8, 2026 •

edited

Loading

coderabbitai bot commented Apr 8, 2026 •

edited

Loading