Skip to content

chore: unsupported covered by#9870

Merged
Netail merged 2 commits intomainfrom
chore/unsupported-qwik-unused-server
Apr 8, 2026
Merged

chore: unsupported covered by#9870
Netail merged 2 commits intomainfrom
chore/unsupported-qwik-unused-server

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Apr 8, 2026

Summary

On request by @dyc3 #9809 (review)

unused-server is covered by noUnusedVariables, but because the names & descriptions differ so much, we list it under unsupported.

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 8, 2026

🦋 Changeset detected

Latest commit: 8c38ec1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Netail Netail force-pushed the chore/unsupported-qwik-unused-server branch from a78d824 to 9bd0078 Compare April 8, 2026 19:36
@github-actions github-actions Bot added the A-CLI Area: CLI label Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5c334ea8-dafd-4315-8b65-14b8497a5375

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd0078 and 8c38ec1.

📒 Files selected for processing (2)
  • .changeset/tired-dolls-knock.md
  • crates/biome_cli/src/execute/migrate/unsupported_rules.rs
✅ Files skipped from review due to trivial changes (1)
  • .changeset/tired-dolls-knock.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/biome_cli/src/execute/migrate/unsupported_rules.rs

Walkthrough

This PR updates the ESLint-to-Biome migration tooling to classify unsupported rules that are already handled by Biome. It adds a new enum variant UnsupportedRuleReason::CoveredByRule(&'static str), updates its display string, surfaces covered rules in migration advices, and registers eslint-qwik’s unused-server as covered by Biome’s noUnusedVariables. A Changeset for @biomejs/biome (patch) was added.

Possibly related PRs

Suggested labels

A-Linter, A-Project

Suggested reviewers

  • dyc3
  • ematipico
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title refers to the core change—marking unused-server as covered by another rule—but is vague and doesn't clearly convey what is being done. Consider a clearer title like 'Mark unused-server ESLint rule as covered by noUnusedVariables' to make the intent more immediately obvious.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the rationale and links to the request, directly addressing why the change was made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/unsupported-qwik-unused-server

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread .changeset/tired-dolls-knock.md Outdated
"@biomejs/biome": patch
---

Make sure to mark eslint-qwik-plugin's `unused-server` as unsupported as it's covered by `noUnusedVariables`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use past tense. As for phrasing, I would call it redundant instead of unsupported

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
crates/biome_cli/src/execute/migrate/eslint_to_biome.rs (1)

252-255: ⚠️ Potential issue | 🟡 Minor

Missing covered_by_rule count in the header summary.

The header message lists counts for all unsupported rule categories except the newly added covered_by_rule. This inconsistency means users won't see the full breakdown.

Suggested fix
             visitor.record_log(
                 biome_diagnostics::LogCategory::Info,
-                &markup! { "Unsupported rules ("{stylistic.len()}" incompatible with formatter, "{formatter_covers.len()}" made obsolete by the formatter, "{formatter_option.len()}" covered by a formatter option, "{known_source_not_implemented.len()}" not yet implemented, "{unknown_source.len()}" unknown source):" },
+                &markup! { "Unsupported rules ("{stylistic.len()}" incompatible with formatter, "{formatter_covers.len()}" made obsolete by the formatter, "{formatter_option.len()}" covered by a formatter option, "{covered_by_rule.len()}" covered by a rule, "{known_source_not_implemented.len()}" not yet implemented, "{unknown_source.len()}" unknown source):" },
             )?;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs` around lines 252 -
255, Update the header summary passed to visitor.record_log to include the count
for covered_by_rule so the unsupported rules breakdown is complete;
specifically, modify the markup string in the call that currently references
stylistic.len(), formatter_covers.len(), formatter_option.len(),
known_source_not_implemented.len(), and unknown_source.len() to also interpolate
covered_by_rule.len() (variable name: covered_by_rule) with a clear label so the
header reflects all categories.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_cli/src/execute/migrate/unsupported_rules.rs`:
- Around line 340-343: The UnsupportedRule entry with
EslintQwik("unused-server") is placed after HtmlEslint entries but must be
ordered by RuleSource enum declaration; move the
UnsupportedRule(EslintQwik("unused-server"), CoveredByRule("noUnusedVariables"))
so it appears before all HtmlEslint entries in the array (i.e., relocate that
tuple to the block where other EslintQwik entries are listed) to satisfy the
ordering expected by test_eslint_unsupported_rules_order.

---

Outside diff comments:
In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs`:
- Around line 252-255: Update the header summary passed to visitor.record_log to
include the count for covered_by_rule so the unsupported rules breakdown is
complete; specifically, modify the markup string in the call that currently
references stylistic.len(), formatter_covers.len(), formatter_option.len(),
known_source_not_implemented.len(), and unknown_source.len() to also interpolate
covered_by_rule.len() (variable name: covered_by_rule) with a clear label so the
header reflects all categories.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 31f2d422-cdcf-4787-b966-fb503f5a597d

📥 Commits

Reviewing files that changed from the base of the PR and between e8cad58 and 9bd0078.

📒 Files selected for processing (3)
  • .changeset/tired-dolls-knock.md
  • crates/biome_cli/src/execute/migrate/eslint_to_biome.rs
  • crates/biome_cli/src/execute/migrate/unsupported_rules.rs

Comment thread crates/biome_cli/src/execute/migrate/unsupported_rules.rs Outdated
@Netail Netail merged commit ccf9770 into main Apr 8, 2026
14 checks passed
@Netail Netail deleted the chore/unsupported-qwik-unused-server branch April 8, 2026 20:35
@github-actions github-actions Bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants