Conversation
🦋 Changeset detectedLatest commit: 8c38ec1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a78d824 to
9bd0078
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR updates the ESLint-to-Biome migration tooling to classify unsupported rules that are already handled by Biome. It adds a new enum variant Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Make sure to mark eslint-qwik-plugin's `unused-server` as unsupported as it's covered by `noUnusedVariables`. |
There was a problem hiding this comment.
Use past tense. As for phrasing, I would call it redundant instead of unsupported
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/biome_cli/src/execute/migrate/eslint_to_biome.rs (1)
252-255:⚠️ Potential issue | 🟡 MinorMissing
covered_by_rulecount in the header summary.The header message lists counts for all unsupported rule categories except the newly added
covered_by_rule. This inconsistency means users won't see the full breakdown.Suggested fix
visitor.record_log( biome_diagnostics::LogCategory::Info, - &markup! { "Unsupported rules ("{stylistic.len()}" incompatible with formatter, "{formatter_covers.len()}" made obsolete by the formatter, "{formatter_option.len()}" covered by a formatter option, "{known_source_not_implemented.len()}" not yet implemented, "{unknown_source.len()}" unknown source):" }, + &markup! { "Unsupported rules ("{stylistic.len()}" incompatible with formatter, "{formatter_covers.len()}" made obsolete by the formatter, "{formatter_option.len()}" covered by a formatter option, "{covered_by_rule.len()}" covered by a rule, "{known_source_not_implemented.len()}" not yet implemented, "{unknown_source.len()}" unknown source):" }, )?;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs` around lines 252 - 255, Update the header summary passed to visitor.record_log to include the count for covered_by_rule so the unsupported rules breakdown is complete; specifically, modify the markup string in the call that currently references stylistic.len(), formatter_covers.len(), formatter_option.len(), known_source_not_implemented.len(), and unknown_source.len() to also interpolate covered_by_rule.len() (variable name: covered_by_rule) with a clear label so the header reflects all categories.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_cli/src/execute/migrate/unsupported_rules.rs`:
- Around line 340-343: The UnsupportedRule entry with
EslintQwik("unused-server") is placed after HtmlEslint entries but must be
ordered by RuleSource enum declaration; move the
UnsupportedRule(EslintQwik("unused-server"), CoveredByRule("noUnusedVariables"))
so it appears before all HtmlEslint entries in the array (i.e., relocate that
tuple to the block where other EslintQwik entries are listed) to satisfy the
ordering expected by test_eslint_unsupported_rules_order.
---
Outside diff comments:
In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs`:
- Around line 252-255: Update the header summary passed to visitor.record_log to
include the count for covered_by_rule so the unsupported rules breakdown is
complete; specifically, modify the markup string in the call that currently
references stylistic.len(), formatter_covers.len(), formatter_option.len(),
known_source_not_implemented.len(), and unknown_source.len() to also interpolate
covered_by_rule.len() (variable name: covered_by_rule) with a clear label so the
header reflects all categories.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 31f2d422-cdcf-4787-b966-fb503f5a597d
📒 Files selected for processing (3)
.changeset/tired-dolls-knock.mdcrates/biome_cli/src/execute/migrate/eslint_to_biome.rscrates/biome_cli/src/execute/migrate/unsupported_rules.rs
Summary
On request by @dyc3 #9809 (review)
unused-serveris covered bynoUnusedVariables, but because the names & descriptions differ so much, we list it under unsupported.Test Plan
Docs