crates/biome_service/src/workspace/document/services/embedded_bindings.rs (1)

116-124: Avoid dual paths for default import registration.

Line 116-124 already handles default imports generically; Line 126-134 re-handles default clauses again. It works, but it’s duplicate logic and easy to desynchronise later.

Suggested tidy-up

-        if let Some(default_specifiers) = clause.default_specifiers() {
-            let local_name = default_specifiers.local_name().ok()?;
+        if let Some(default_specifier) = clause.default_specifiers() {
+            let local_name = default_specifier.local_name().ok()?;
             let local_name = local_name.as_js_identifier_binding()?;
             let local_name = local_name.name_token().ok()?;
             self.js_bindings.insert(
                 local_name.text_trimmed_range(),
                 local_name.token_text_trimmed(),
             );
         }
-
-        // Handle default clause using accessors generated by the syntax crate.
-        if let Some(import) = clause.as_js_import_default_clause() {
-            let name = import.default_specifier().ok()?;
-            let name = name.local_name().ok()?;
-            let name = name.as_js_identifier_binding()?;
-            let name = name.name_token().ok()?;
-            self.js_bindings
-                .insert(name.text_trimmed_range(), name.token_text_trimmed());
-        }

One code path, one source of truth — future-you will thank present-you.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_service/src/workspace/document/services/embedded_bindings.rs`
around lines 116 - 124, The code currently registers default imports in two
places causing duplicated logic; keep the existing generic path that extracts
default_specifiers via clause.default_specifiers(), converts through
as_js_identifier_binding() and name_token(), and inserts into self.js_bindings
using text_trimmed_range() and token_text_trimmed(), and remove the redundant
second block that re-handles default clauses (the duplicate that performs the
same local_name extraction and self.js_bindings.insert). Consolidate any
remaining variant-specific logic into the single clause.default_specifiers()
path so there's one source of truth for default import registration.