fix(@commitlint/load): Remove unused @types/node dependency#3801
Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom Nov 29, 2023
askoufis:remove-commitlint-load-node-types-dep
Merged
fix(@commitlint/load): Remove unused @types/node dependency#3801escapedcat merged 1 commit intoconventional-changelog:masterfrom askoufis:remove-commitlint-load-node-types-dep
@types/node dependency#3801escapedcat merged 1 commit intoconventional-changelog:masterfrom
askoufis:remove-commitlint-load-node-types-dep
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@commitlint/loadhas both a regular and dev dependency on@types/node. Only one of these should be needed, and it seems that the regular dependency is not required since the package's API does not rely on these types, so I have removed it. The dev dependency needs to stay asnode:pathis used in this package.Motivation and Context
The
@types/nodedependency could result in multiple major versions of@types/nodein a consumer'snode_modules, e.g. if a consumer also depends on@types/node@20. This isn't a huge deal, but IMO it's still worth fixing if possible.Usage examples
N/A
How Has This Been Tested?
The build output (specifically
.d.tsfiles) before and after this change is identical.Types of changes
Checklist: