GitHubCI: no need to just run in master branch#3840
Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom Jan 4, 2024
Merged
GitHubCI: no need to just run in master branch#3840escapedcat merged 1 commit intoconventional-changelog:masterfrom
escapedcat merged 1 commit intoconventional-changelog:masterfrom
Conversation
When a contributor wants to create a PR for commitlint, the normal thing for him to do first is fork the repo and create a branch with a different name than master. Then, if he pushes his commits, he should be able to see the CI status of his fixes before he opens the PR.
escapedcat
added a commit
that referenced
this pull request
Mar 17, 2026
…te runs Reverts the push trigger from `master`-only back to `"**"` (all branches) so contributors can see CI status before opening a PR (#3840). Adds a concurrency group to cancel duplicate runs when both push and pull_request triggers fire for the same branch. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
escapedcat
added a commit
that referenced
this pull request
Mar 17, 2026
…te runs Reverts the push trigger from `master`-only back to `"**"` (all branches) so contributors can see CI status before opening a PR (#3840). Adds a concurrency group to cancel duplicate runs when both push and pull_request triggers fire for the same branch. The concurrency group includes the repo name to prevent cross-fork collisions, and gives scheduled runs a unique group so they can't be cancelled by push events. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
escapedcat
added a commit
that referenced
this pull request
Mar 17, 2026
Reverts the push trigger from `master`-only back to `"**"` (all branches) so contributors can see CI status on their fork branches before opening a PR (see #3840). To avoid duplicate CI runs when a maintainer pushes to a branch that has an open PR (both push and pull_request triggers fire), each job now has an `if` condition that skips pull_request runs from the same repository. This is the same approach used by Vue.js (vuejs/core): - Push events: always run - Pull request events: only run if the PR is from a fork - Schedule/workflow_dispatch: always run This avoids the "50% broken CI" visual noise caused by concurrency groups cancelling push runs, since GitHub shows cancelled jobs as failures. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
escapedcat
added a commit
that referenced
this pull request
Mar 18, 2026
Reverts the push trigger from `master`-only back to `"**"` (all branches) so contributors can see CI status on their fork branches before opening a PR (see #3840). To avoid duplicate CI runs when a maintainer pushes to a branch that has an open PR (both push and pull_request triggers fire), each job now has an `if` condition that skips pull_request runs from the same repository. This is the same approach used by Vue.js (vuejs/core): - Push events: always run - Pull request events: only run if the PR is from a fork - Schedule/workflow_dispatch: always run This avoids the "50% broken CI" visual noise caused by concurrency groups cancelling push runs, since GitHub shows cancelled jobs as failures. Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a contributor wants to create a PR for commitlint, the normal thing for him to do first is fork the repo and create a branch with a different name than master. Then, if he pushes his commits, he should be able to see the CI status of his fixes before he opens the PR.