fix(core): align file stats with parquet read schema#4130
Merged
roeap merged 1 commit intodelta-io:mainfrom Jan 27, 2026
Merged
fix(core): align file stats with parquet read schema#4130roeap merged 1 commit intodelta-io:mainfrom
roeap merged 1 commit intodelta-io:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
==========================================
- Coverage 76.09% 76.05% -0.04%
==========================================
Files 164 164
Lines 45095 44824 -271
Branches 45095 44824 -271
==========================================
- Hits 34314 34092 -222
+ Misses 9138 9113 -25
+ Partials 1643 1619 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d645370 to
0181598
Compare
Signed-off-by: Robert Pack <[email protected]>
0181598 to
28b06a5
Compare
rtyler
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the update to DF 52 we needed to introduce a
PhysicalExprAdapterto handle some test failures, but it did elude me why that would be needed. While trying to get rid of it I believe I found the root cause.As we see in #4127, we need to be very deliberate when it comes to schemas and expressions. I think the DF update introduced an optimization in that if the optimizer can prove that a value is constant within a file via file stats, it replaces the column reference with a literal value taken from the file stats. However the file stats were not aligned to the physical read schema but were using default types leading to invalid comparisons.
This PR also cleans up some unused fields/structs that are leftovers from previous refactors.
cc: @ethan-tyler