feat: update asserted nullability in DataValidation output schema#4132
Merged
rtyler merged 2 commits intodelta-io:mainfrom Jan 27, 2026
Merged
feat: update asserted nullability in DataValidation output schema#4132rtyler merged 2 commits intodelta-io:mainfrom
rtyler merged 2 commits intodelta-io:mainfrom
Conversation
Signed-off-by: Robert Pack <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
+ Coverage 76.18% 76.21% +0.03%
==========================================
Files 164 164
Lines 45024 45446 +422
Branches 45024 45446 +422
==========================================
+ Hits 34300 34638 +338
- Misses 9096 9173 +77
- Partials 1628 1635 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roeap
commented
Jan 27, 2026
Comment on lines
+278
to
+281
| to_datafusion_expr( | ||
| &Expression::Column(col.clone()), | ||
| &delta_kernel::schema::DataType::BOOLEAN, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
we run this through kernel conversion since field access is a bit cumbersome to resolve on the DF side and its already handled there.
rtyler
reviewed
Jan 27, 2026
Comment on lines
+691
to
+695
| // DataType::List(child) | DataType::LargeList(child) => { | ||
| // let mut child_path = current_path.clone(); | ||
| // child_path.push("element".to_string()); | ||
| // collect_non_nullable_fields_recursive(child, child_path, non_nullable_paths); | ||
| // } |
Member
There was a problem hiding this comment.
por que?
If this code is meant to be implemented later, I would rather see a todo!()
Signed-off-by: Robert Pack <[email protected]>
rtyler
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following our newly introduces AI disclosure guidelines - I used AI to write the recursive methods that update field nullability.
In the current refactoring efforts, we are combining more and more operations into logical plans and further defer doing physical work. In some cases we combine data that may differ in the logical nullability, but be equivalent in practical terms - i.e. no null values present, in nullable field.
We assert the absence of null values in the
DataValidationExec, to be able to combine different sources (usually inserted data and data rescued from exisiting files) we also need to update the schema to be matching in null values.