Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.17%. Comparing base (6ee66e2) to head (f2d76dc).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #4142      +/-   ##
==========================================
- Coverage   76.23%   76.17%   -0.06%     
==========================================
  Files         164      164              
  Lines       45468    45471       +3     
  Branches    45468    45471       +3     
==========================================
- Hits        34661    34638      -23     
- Misses       9171     9198      +27     
+ Partials     1636     1635       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco if this version of the python package were used in the future with a datafusion-ffi of 53 wouldn't there still likely be a SIGSEGV due to ABI incompatibilities?

Basically as I understand the problem here, this version number will have to change as newer major releases are built into our wheels

@ion-elgreco if this version of the python package were used in the future with a datafusion-ffi of 53 wouldn't there still likely be a SIGSEGV due to ABI incompatibilities?

Basically as I understand the problem here, this version number will have to change as newer major releases are built into our wheels

Only if the ffi interface changes but that's assuming we will have breaking changes every major release of datafusion-ffi. But before it was working for multiple major versions

@ion-elgreco in the future we can update the check with the new major versions, but I think we should be strict until newer versions are proven to work. The consequences of failing is a complete segfault which is about as disastrous of an outcome as it gets

@rtyler alright that's fair