refactor: add FileSelection to next provider for DeltaTableProvider removal#4172
Merged
ion-elgreco merged 3 commits intodelta-io:mainfrom Feb 7, 2026
Merged
Conversation
Signed-off-by: Ethan Urbanski <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
==========================================
+ Coverage 76.36% 76.61% +0.25%
==========================================
Files 166 166
Lines 46308 46774 +466
Branches 46308 46774 +466
==========================================
+ Hits 35364 35838 +474
+ Misses 9263 9213 -50
- Partials 1681 1723 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
reviewed
Feb 7, 2026
Collaborator
ion-elgreco
left a comment
There was a problem hiding this comment.
Looks good! Just two notes, I would make the tests more explicit in terms of file length checks and row size checks, instead of selected < base. And I would look into retaining files before visiting with kernel
Signed-off-by: Ethan Urbanski <[email protected]>
ion-elgreco
reviewed
Feb 7, 2026
Signed-off-by: Ethan Urbanski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DML operations scope scans to specific files via
DeltaTableProvider::with_files(Vec<Add>). The next provider (DeltaScan)has no equivalent. This PR adds that foundation.
Introduces
FileSelectionapub(crate)struct holding normalized file IDs(
HashSet<String>) that scopes scans to specific files. Unselected files areexcluded in the replay phase before DV tasks or data reads are produced.
No callers yet and will be added when DML operations migrate.
Migration path
FileSelection, wire intoDeltaScanpipelineDeltaTableProvider::with_files(Vec<Add>)toDeltaScan::with_file_selection(FileSelection::from_adds(...))FileSelection::from_pathsDeltaTableProviderandwith_filesCC: @roeap
Related Issue(s)
Documentation