Merged
Conversation
Contributor
Author
|
I'll add a separate |
Contributor
Author
Done. |
brrygrdn
reviewed
Feb 22, 2022
| targetBranch: string, | ||
| prevVersion: string, | ||
| newVersion: string, | ||
| compatScore: number |
Contributor
There was a problem hiding this comment.
I'll need to double check out API to see how we handle Dependency Score unknown in the API as I can't remember off the top of my head.
brrygrdn
reviewed
Feb 22, 2022
Contributor
brrygrdn
left a comment
There was a problem hiding this comment.
I just need to double check our API behaviour in one case, otherwise this looks great.
Thanks for adding a separate input flag for this lookup as well 🚀
brrygrdn
reviewed
Feb 28, 2022
| }) | ||
|
|
||
| const scoreChunk = svg.match(/<title>compatibility: (?<score>\d+)%<\/title>/m) | ||
| return scoreChunk?.groups ? parseInt(scoreChunk.groups.score) : 0 |
Contributor
There was a problem hiding this comment.
Just double-checking, when we have an incompatible badge, e.g.
Line 114 will extract the word unknown, which evaluates to 0 here, so that's all good 👍🏻
brrygrdn
approved these changes
Feb 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #98
NOTE: This PR is a branch off of (and depends upon #144), so merging this one first would also merge that one too.