fix: improve VulnerableSoftware comparison#8031
Merged
jeremylong merged 1 commit intomainfrom Oct 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses intermittent test failures by improving the comparison logic in the VulnerableSoftware class to handle null and empty string values consistently.
- Adds a utility method to normalize null and empty strings for comparison
- Updates the compareTo method to use normalized values for version-related fields
- Ensures consistent comparison behavior regardless of whether fields contain null or empty strings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Intermittent test failure, as seen https://github.com/dependency-check/DependencyCheck/actions/runs/18444777553/job/52549923196. Amp suggested this fix to resolve the failure.