Fix functions call with extra parameter#245
Merged
dougwilson merged 1 commit intoexpressjs:masterfrom May 14, 2022
Merged
Conversation
dougwilson
approved these changes
May 14, 2022
Contributor
dougwilson
left a comment
There was a problem hiding this comment.
sorry this sat here! lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions are being called with "req" as second parameter, but it's not required nor is useful in any way, this does not affect the functionality but this should not be done, javascript allows it but it is a little confusing when reading it.
example:
headers.push(configureCredentials(options, req)); ---> headers.push(configureCredentials(options));
the function is declared this way:
function configureCredentials(options) {...