Skip to content

fix(a11y): add Space key support for navbar dropdowns#11513

Merged
slorber merged 1 commit intofacebook:mainfrom
TheCyperpunk:main
Dec 5, 2025
Merged

fix(a11y): add Space key support for navbar dropdowns#11513
slorber merged 1 commit intofacebook:mainfrom
TheCyperpunk:main

Conversation

@TheCyperpunk
Copy link
Copy Markdown
Contributor

@TheCyperpunk TheCyperpunk commented Oct 27, 2025 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 27, 2025

Hi @TheCyperpunk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 27, 2025

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d8d5de
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/68ff2ecab2503f0008a1ded3
😎 Deploy Preview https://deploy-preview-11513--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@TheCyperpunk
Copy link
Copy Markdown
Contributor Author

TheCyperpunk commented Oct 27, 2025

I signed on CLA , now review and merge my PR

@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Oct 27, 2025
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Oct 27, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Dec 5, 2025

Seems to work well thanks 👍

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 5, 2025
@slorber slorber merged commit 59bce2b into facebook:main Dec 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheCyperpunk @slorber