feat(theme): Use React context for <Tabs>, allow custom <TabItem> components#11733
Merged
feat(theme): Use React context for <Tabs>, allow custom <TabItem> components#11733
<Tabs>, allow custom <TabItem> components#11733Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +268 B (0%) Total Size: 11.8 MB ℹ️ View Unchanged
|
7 tasks
⚡️ Lighthouse report for the deploy preview of this PR
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Size Change: +258 B (0%) Total Size: 12.3 MB ℹ️ View Unchanged
|
Contributor
|
@slorber Detailselement might already handles show/hideautomatically |
Collaborator
Author
|
@akshatsinha0 I'm not sure I understand what you mean exactly, but I'd rather not refactor this Details component at this point because we want to re-implement this later and get closer to the native details behavior. Our current implementation has issues, and new browser capabilities are deployed to support collapsing animations without JS. See also #10055 |
Contributor
Got it, makes sense ; I was thinking about it from the wrong angle. Checked it out, the CSS only approach using ::details-content transitions is different direction. |
|
It looks like this change broke |
sserrata
added a commit
to PaloAltoNetworks/docusaurus-openapi-docs
that referenced
this pull request
Apr 8, 2026
Docusaurus 3.10.0 refactored the internal Tabs system to use React context (facebook/docusaurus#11733), breaking all custom tab components. - Replace useTabs(props) with useTabsContextValue(props) + TabsProvider - Remove cloneElement hidden prop injection (TabItem self-manages via context) - Consolidate imports to @docusaurus/theme-common/internal (deep lib/ paths are now restricted by the package exports field) - Update ambient type declarations in theme-classic.d.ts - Bump Docusaurus peerDeps/devDeps to ^3.10.0 Closes #1395 Co-Authored-By: Claude Opus 4.6 <[email protected]>
4 tasks
sserrata
added a commit
to PaloAltoNetworks/docusaurus-openapi-docs
that referenced
this pull request
Apr 8, 2026
* fix: update Tabs API for Docusaurus 3.10.0 compatibility Docusaurus 3.10.0 refactored the internal Tabs system to use React context (facebook/docusaurus#11733), breaking all custom tab components. - Replace useTabs(props) with useTabsContextValue(props) + TabsProvider - Remove cloneElement hidden prop injection (TabItem self-manages via context) - Consolidate imports to @docusaurus/theme-common/internal (deep lib/ paths are now restricted by the package exports field) - Update ambient type declarations in theme-classic.d.ts - Bump Docusaurus peerDeps/devDeps to ^3.10.0 Closes #1395 Co-Authored-By: Claude Opus 4.6 <[email protected]> * refactor: remove unnecessary cloneElement in non-lazy TabContent With TabItem now self-managing visibility via context, the cloneElement call that only injected key was dead weight. Render children directly instead. Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
clementnero
added a commit
to camunda/camunda-docs
that referenced
this pull request
Apr 12, 2026
…cusaurus 3.10.0 upgrade @camunda8/docusaurus-theme-openapi-docs 4.6.4 pulls in @docusaurus/* 3.10.0 as transitive dependencies, which introduces a breaking React Context change in Tabs (facebook/docusaurus#11733) causing SSG failures across all versioned docs pages (ReactContextError at useDocsPreferredVersionContext). Additionally, Docusaurus 3.10.0 renamed 'experimental_faster' to 'faster' in the site config, which is incompatible with 3.9.x. Pin the OpenAPI packages to exact 4.6.3 and keep Docusaurus at 3.9.2 until the OpenAPI theme is updated for Docusaurus 3.10.0 compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The theme
<Tabs>component implementation was not very flexible to support many composition patterns, assuming that<TabItem>must be a direct child of<Tabs>to work, relying onelement.props.valueandcloneElement()clunky APIs.This PR introduces a context for each
<Tabs>so that<TabItem>can be wrapped in more flexible ways.This required some refactoring that also cleans up a bit of this historically complex component. The component can be further simplified / splitted in follow up PRs.
Fix #11672
Test Plan
CI + unit tests + dogfood + Argos
Test links
https://deploy-preview-11733--docusaurus-2.netlify.app/docs/markdown-features/tabs
https://deploy-preview-11733--docusaurus-2.netlify.app/tests/pages/tabs-tests