console logger HTTP status code bug fixed#3453
Merged
thinkerou merged 1 commit intogin-gonic:masterfrom Jan 2, 2023
Merged
Conversation
Member
|
@alirezaeftekhari Please add unit testing. |
017954f to
20bf2f7
Compare
Contributor
Author
|
@appleboy Done |
appleboy
approved these changes
Jan 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #3453 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3139 3140 +1
=======================================
+ Hits 3096 3097 +1
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thinkerou
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@manucorporat @thinkerou @appleboy
Hello Dears.
It looks like the console logger HTTP response code is not equal to the client(browser) HTTP status code in the case we set the response status code twice or more by mistake or whatever.
It would make some problems when we want to monitor our network traffic because the status code which we have is not right.
Please consider the following code:
If we make an HTTP request by curl:
We'll get 200 status by curl, but the console logger prints 401, and its not true.
I fixed this problem by preventing rewriting the HTTP status code in the response writer and It's working fine now.
Regards.