chore(router): match method added to routergroup for multiple HTTP methods supporting#3464
Merged
appleboy merged 1 commit intogin-gonic:masterfrom Feb 6, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3464 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3140 3145 +5
=======================================
+ Hits 3097 3102 +5
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abhiyankhanal
approved these changes
Jan 12, 2023
appleboy
approved these changes
Feb 6, 2023
thinkerou
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the Match method to the IRoutes interface and RouterGroup struct for supporting multiple HTTP methods with single functionality and handler.
For example, this is common to use both PUT and PATCH methods when developing RESTful APIs for updating models.
Without this method, we should repeat ourselves to handle this.
With the Match method our routing signature is like this: