Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I'll check. I assumed I am already in the CLA as others from 9e contributed...

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

I'll check. I assumed I am already in the CLA as others from 9e contributed...

@mynetz I don't claim to super understand the Google CLA system but I believe that the CLA expects an entry for each individual contributor. While a few others from 9elements have already contributed I think it wants to see a signature from you as well.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

I'll check. I assumed I am already in the CLA as others from 9e contributed...

@mynetz I don't claim to super understand the Google CLA system but I believe that the CLA expects an entry for each individual contributor. While a few others from 9elements have already contributed I think it wants to see a signature from you as well.

Yes. I needed to be added somewhere. Now the validation succeeded.

Thanks again for the change @mynetz!

@chrisfenner: You're welcome. The abstraction you (plural) choose for the API makes this form of contribution very eays.

I'll use this brief exchange for a question: While trying to understand the go-tpm/tpm2 code and also the problem, I saw that there is no example code in go-tpm/examples for the newer tpm2 API. I did build an example for myself using an NVRAM space and a PCR policy to access. Would this be of interest for the project?

Then I polish up the code and create a PR: https://gist.github.com/mynetz/552200d13d3e0386a57d009a435bd0b8

@chrisfenner: You're welcome. The abstraction you (plural) choose for the API makes this form of contribution very eays.

I'll use this brief exchange for a question: While trying to understand the go-tpm/tpm2 code and also the problem, I saw that there is no example code in go-tpm/examples for the newer tpm2 API. I did build an example for myself using an NVRAM space and a PCR policy to access. Would this be of interest for the project?

Then I polish up the code and create a PR: https://gist.github.com/mynetz/552200d13d3e0386a57d009a435bd0b8

Thank you!

Yes, I think example code using the new API is of general interest. Today our "new API" examples are all in https://github.com/google/go-tpm/tree/main/tpm2/test. But an examples directory right next to it would be awesome.

If you wanted to create an examples/tpm-nv (or whatever) directory based on https://gist.github.com/mynetz/552200d13d3e0386a57d009a435bd0b8 I'd be happy to approve the PR.