Make Token a sealed interface rather than a record with a Type enum.#1365
Closed
copybara-service[bot] wants to merge 0 commit intomasterfrom
Closed
Make Token a sealed interface rather than a record with a Type enum.#1365copybara-service[bot] wants to merge 0 commit intomasterfrom
Token a sealed interface rather than a record with a Type enum.#1365copybara-service[bot] wants to merge 0 commit intomasterfrom
Conversation
a4189e3 to
e9e9d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Tokena sealed interface rather than a record with aTypeenum.I think this is a bit cleaner, and it will also make it possible to associate additional information with particular token types. I have something in mind for a new
CodeBlocktoken.