Add EdDSA algorithm encoding/decoding usage#993
Merged
jpadilla merged 1 commit intojpadilla:masterfrom Oct 8, 2024
Merged
Conversation
Contributor
Author
|
@jpadilla, if possible, could you review the PR? Thanks :). |
jpadilla
approved these changes
Oct 7, 2024
jpadilla
requested changes
Oct 7, 2024
Owner
jpadilla
left a comment
There was a problem hiding this comment.
thank you! mind updating and fixing conflicts?
4061ca1 to
1960fec
Compare
Contributor
Author
|
@jpadilla, I've resolved PR conflicts, please review this PR at your available time. Thanks! |
jpadilla
requested changes
Oct 8, 2024
Comment on lines
+72
to
+73
| >>> print(encoded) | ||
| eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJzb21lIjoicGF5bG9hZCJ9.yPJ7Ggb6aOZn38vNai8bBN6bgfcrzKXSTsdXeGsZGibnxSZrWDrWeB6p35f9RFkMnYgToe_eh4mgye5V6wj5DQ |
Owner
There was a problem hiding this comment.
Suggested change
| >>> print(encoded) | |
| eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJzb21lIjoicGF5bG9hZCJ9.yPJ7Ggb6aOZn38vNai8bBN6bgfcrzKXSTsdXeGsZGibnxSZrWDrWeB6p35f9RFkMnYgToe_eh4mgye5V6wj5DQ |
Contributor
Author
There was a problem hiding this comment.
Do we really need to remove encoded printing?
If we remove encoded printing, I think the encoded variable will be unused.
Owner
There was a problem hiding this comment.
the exact string representation of the token matters less and can fail dockets.
encoded is used in the decode step below.
Contributor
Author
There was a problem hiding this comment.
I see. The encoded presenting has been removed.
1960fec to
5acba65
Compare
jpadilla
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title, adding the
EdDSAalgorithm to encode/decode usage.