feat(sign): add generics to sign and sign async methods#1946
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Oct 10, 2025
ahmedwael216:add-generics-to-sign
Merged
feat(sign): add generics to sign and sign async methods#1946kamilmysliwiec merged 1 commit intonestjs:masterfrom ahmedwael216:add-generics-to-sign
kamilmysliwiec merged 1 commit intonestjs:masterfrom
ahmedwael216:add-generics-to-sign
Conversation
|
Finally this pr |
micalevisk
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
the sign ans sign async when provided with an object don't accept generics, while the decode does,
What is the new behavior?
make the sign and sign async accept generics when provided an object, this increases type safety and prevents DX
Does this PR introduce a breaking change?